Skip to content

Fix keyboard accessibility for SplitButton color picker flyouts (MAS 2.1.1) #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pranav-gupta-msft wants to merge 1 commit into from
+10 −2
Closed

Fix keyboard accessibility for SplitButton color picker flyouts (MAS 2.1.1) #2118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion WinUIGallery/Samples/ControlPages/SplitButtonPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@
MinHeight="0"
Padding="5"
VerticalAlignment="Top"
AutomationProperties.Name="Font color with text">
AutomationProperties.Name="Font color with text"
Click="myColorButtonReveal_Click">
Choose color
<SplitButton.Flyout>
<Flyout Placement="Bottom">
Expand Down
7 changes: 7 additions & 0 deletions WinUIGallery/Samples/ControlPages/SplitButtonPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,20 @@ private void RevealColorButton_Click(object sender, RoutedEventArgs e)
myColorButtonReveal.Flyout.Hide();
}

private void myColorButtonReveal_Click(SplitButton sender, SplitButtonClickEventArgs args)
{
sender.Flyout.ShowAt(sender);
}

private void myColorButton_Click(Microsoft.UI.Xaml.Controls.SplitButton sender, Microsoft.UI.Xaml.Controls.SplitButtonClickEventArgs args)
{
var border = (Border)sender.Content;
var color = ((Microsoft.UI.Xaml.Media.SolidColorBrush)border.Background).Color;

myRichEditBox.Document.Selection.CharacterFormat.ForegroundColor = color;
currentColor = color;

sender.Flyout.ShowAt(sender);
}

private void MyRichEditBox_TextChanged(object sender, RoutedEventArgs e)
Expand Down
2 changes: 1 addition & 1 deletion WinUIGallery/Samples/SampleCode/Buttons/SplitButton/SplitButtonSample2.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<SplitButton x:Name="myColorButton">
<SplitButton x:Name="myColorButton" Click="myColorButton_Click">
Choose color
<SplitButton.Flyout>
<Flyout Placement="Bottom">
Expand Down