Fix keyboard accessibility for SplitButton color picker flyouts (MAS 2.1.1)#2118
Closed
pranav-gupta-msft wants to merge 1 commit intomainfrom
Closed
Fix keyboard accessibility for SplitButton color picker flyouts (MAS 2.1.1)#2118pranav-gupta-msft wants to merge 1 commit intomainfrom
pranav-gupta-msft wants to merge 1 commit intomainfrom
Conversation
…2.1.1) Add Click handlers to both SplitButtons so the color picker flyout opens when activated via keyboard (Enter/Space). Previously, keyboard and assistive technology users could not expand the "Choose color" flyout. - Add myColorButtonReveal_Click handler that opens the flyout on the text SplitButton - Open the flyout from myColorButton_Click on the RichEditBox SplitButton - Update SplitButtonSample2.txt to reflect the new Click handler
Member
|
I think this behavior should be fixed in the control, rather than in the sample here. I will look through the issue more comprehensively and get back. But the fix looks good if the requirement is to fix it here |
Member
Author
|
Agreed. Closing the PR, since, it is not a correct solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed keyboard accessibility for SplitButton color picker flyouts on the SplitButton sample page. Both SplitButton controls ("Font color" and "Choose color") now open their color picker flyouts when activated via keyboard (Enter/Space). Previously, keyboard and assistive technology users could not expand the flyouts to access the color options.
Changes:
Click="myColorButtonReveal_Click"to the "Choose color" SplitButton in XAMLmyColorButtonReveal_Clickhandler that programmatically opens the flyout viasender.Flyout.ShowAt(sender)myColorButton_Clickto also open the flyout after applying the selected colorSplitButtonSample2.txtsample code to include theClickhandler for consistencyMotivation and Context
Keyboard and assistive technology users were unable to expand the color picker flyouts on the SplitButton page. When navigating to either SplitButton and pressing Enter/Space, nothing happened — the flyout would not open, preventing users from selecting a color. This is a violation of MAS 2.1.1 – Keyboard (Trap ID: 2.1 - Physical Challenge), which requires all functionality to be operable via keyboard.
How Has This Been Tested?
Types of changes