Skip to content

test(storage): add conformance test for ranged reads #13645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cpriti-os wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test(storage): add conformance test for ranged reads #13645

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cddb95
test(storage): add conformance test for ranged reads
cpriti-os Jan 19, 2026
9945c44
update storage/retry_conformance_test.go
cpriti-os Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions storage/retry_conformance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,35 @@ var methods = map[string][]retryFunc{
}
return err
},
func(ctx context.Context, c *Client, fs *resources, _ bool) error {
// Upload 3MiB of data. This provides enough data to ensure retries happen mid-stream.
objName := objectIDs.New()
if err := uploadTestObject(fs.bucket.Name, objName, randomBytes3MiB); err != nil {
return fmt.Errorf("failed to upload 3MiB object: %v", err)
}

obj := c.Bucket(fs.bucket.Name).Object(objName)
r, err := obj.NewRangeReader(ctx, 0, 3*MiB)
if err != nil {
return err
}
defer r.Close()

// Request the full 3MiB range.
// The emulator's fault injection (e.g., reset-connection) will trigger mid-download.
buf, err := io.ReadAll(r)
if err != nil {
return fmt.Errorf("resumption test failed: %v", err)
}

if int64(len(buf)) != 3*MiB {
return fmt.Errorf("resumption data length mismatch: got %d, want %d", len(buf), 3*MiB)
}
if !bytes.Equal(buf, randomBytes3MiB) {
return fmt.Errorf("resumption data mismatch: content does not match randomBytes3MiB")
}
return nil
},
func(ctx context.Context, c *Client, fs *resources, _ bool) error {
// Test JSON reads.
client, ok := c.tc.(*httpStorageClient)
Expand Down
Loading