Skip to content

test(storage): add conformance test for ranged reads#13645

Open
cpriti-os wants to merge 2 commits intogoogleapis:mainfrom
cpriti-os:range
Open

test(storage): add conformance test for ranged reads#13645
cpriti-os wants to merge 2 commits intogoogleapis:mainfrom
cpriti-os:range

Conversation

@cpriti-os
Copy link
Contributor

No description provided.

@cpriti-os cpriti-os requested a review from a team as a code owner January 19, 2026 04:38
@cpriti-os cpriti-os requested a review from a team January 19, 2026 04:38
@cpriti-os cpriti-os requested a review from a team as a code owner January 19, 2026 04:38
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jan 19, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @cpriti-os, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new conformance test within the storage package. The primary goal of this test is to ensure the robustness of ranged read operations, particularly when network interruptions or fault injections occur during data transfer. By simulating a large download and verifying its integrity, the change enhances the reliability of the storage client's ability to handle partial reads and retries.

Highlights

  • New Conformance Test for Ranged Reads: A new test case has been added to storage/retry_conformance_test.go to specifically validate ranged read operations.
  • Retry/Resumption Validation: The test uploads a 3MiB object and then performs a ranged read of the entire object, designed to trigger mid-download retries or resumptions via fault injection (e.g., connection resets).
  • Data Integrity Verification: The test verifies that the full 3MiB of data is correctly read and that its content matches the original uploaded data, ensuring data integrity during potentially interrupted transfers.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a conformance test for ranged reads to verify download resumption. The test uploads a 3MiB object, reads it back using a range reader, and verifies the content. The test logic is sound, but I've found a potential resource leak due to the misplacement of a defer statement. My review includes a suggestion to fix this.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant