Add test case where IteratorBindingInitialization-BindingElement IteratorStepValue throws#4925
Open
Add test case where IteratorBindingInitialization-BindingElement IteratorStepValue throws#4925
Conversation
G-Lee1031
force-pushed
the
iteratorstepvalue
branch
2 times, most recently
from
ca77d61 to
a9bcc21
Compare
G-Lee1031
force-pushed
the
iteratorstepvalue
branch
from
a9bcc21 to
0ebea4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
This PR adds an abrupt completion returning case of IteratorBindingInitialization of BindingElement : BindingPattern Initializer? step 2.a.
In BindingInitialization step 1, iteratorRecord is obtained by GetIterator. In this particular PR, since the source method is an async function, iteratorRecord is defined such that its [[Iterator]] internal slot holds a Promise object, and [[NextMethod]] is set to
undefined.In IteratorBindingInitialization of BindingElement : BindingPattern step 2.a IteratorStepValue(iteratorRecord) is called.
IteratorStepValue calls IteratorStep(iteratorRecord) in step 1.
IteratorStep calls IteratorNext(iteratorRecord, optional value) in step 1.
Since value is not present, in IteratorNext step 1.a, iteratorRecord.[[NextMethod]] is called. However, since iteratorRecord.[[NextMethod]] is set as
undefined, IsCallable(iteratorRecord.[[NextMethod]]) returnsfalse. As a result, Call(iteratorRecord.[[NextMethod]], iteratorRecord.[[Iterator]]) throws a TypeError. As a result, result is set as an abrupt completion.In IteratorNext step 3.b, result which is an abrupt completion, is returned.