Add test case where RestBindingInitialization throws because of getter#4917
Open
Add test case where RestBindingInitialization throws because of getter#4917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
This PR adds a test case where RestBindingInitialization performed in two cases of BindingInitialization throws when getter of the source object throws.
Check 1 covers
ObjectBindingPattern :
{BindingRestProperty}. RestBindingInitialization is performed in step 2.Check 2 covers
ObjectBindingPattern :
{BindingPropertyList,BindingRestProperty}. RestBindingInitialization is performed in step 2.In RestBindingInitialization, CopyDataProperties is performed in step 3. And in CopyDataProperties step 4.c.ii.1, Get(from, nextKey) is called. In this particular PR, I set value as
{get 1 () {throw new Test262Error}};so that Get(from, nextKey) throws.