Delete two-digit-years.js and non-iso.js#4874
Open
Gumichocopengin8 wants to merge 2 commits intotc39:mainfrom
Open
Delete two-digit-years.js and non-iso.js#4874Gumichocopengin8 wants to merge 2 commits intotc39:mainfrom
two-digit-years.js and non-iso.js#4874Gumichocopengin8 wants to merge 2 commits intotc39:mainfrom
Conversation
Gumichocopengin8
changed the title
two-digit-years.jstwo-digit-years.js
Contributor
|
Ref #4788 as well |
Author
|
@Ms2ger Deleted |
Gumichocopengin8
changed the title
two-digit-years.jstwo-digit-years.js and non-iso.js
Gumichocopengin8
changed the title
two-digit-years.js and non-iso.jstwo-digit-years.js and non-iso.js
Author
|
Is there anything else I should do to get a review? |
Contributor
|
The PR itself looks fine. Although I'm not sure if everything in these files is just invalid, or we need to discuss having coverage for web reality in some other way that isn't disruptive for implementations executing the test suite? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on https://tc39.es/ecma262/#sec-date.parse, these test files do not conform to date time string format (https://tc39.es/ecma262/#sec-date-time-string-format). Therefore, remove the files.
close #4788