Conversation
|
We don't support xarray/xarray/core/variable.py Lines 295 to 301 in 2742e22 though we'd like to support In this case, i think |
Oops should have checked that first I guess :) |
xarray/core/variable.py
Outdated
| getattr(data, "_meta", None), np.ma.MaskedArray | ||
| ): | ||
| _dtype, fill_value = dtypes.maybe_promote(data.dtype) | ||
| data = duck_array_ops.filled(data, fill_value) |
There was a problem hiding this comment.
should we use filled for the np.ma path too? Or is it inplace and weird to do that?
There was a problem hiding this comment.
filled does seem like it was clearly designed for this purpose and it doesn't seem like it's inplace. I think you are right. That would be clearer
There was a problem hiding this comment.
Well in retrospect there is some type promotion going on in where_method so maybe the dask version should also just use that.
whats-new.rstI really tried to write a simpler test, but I couldn't quite get it to work.