Skip to content

feat: add introduction encoding#101

Open
osmaczko wants to merge 1 commit intomasterfrom
introduction-encoding
Open

feat: add introduction encoding#101
osmaczko wants to merge 1 commit intomasterfrom
introduction-encoding

Conversation

@osmaczko
Copy link

@osmaczko osmaczko commented Feb 9, 2026


## Security/Privacy Considerations

The Introduction Bundle contains long-term public key material. Publishing it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Pebble] key material is associated with secrets - not simply public key bytes. Needs re-wording.

## Security/Privacy Considerations

The Introduction Bundle contains long-term public key material. Publishing it
reveals the installation's public identity to anyone who receives the bundle.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue can be described more clearly. This currently reads as "If you tell people who you are, they will know who you are."

Where exactly is the concern? What do you think implementors need to be mindful of?

name: introduction-bundle-encoding
category: Standards Track
tags: core, encoding
editor: Patryk <patryk@status.im>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you are listed as the editor. As per 1/COSS is that your intention?

category: Standards Track
tags: core, encoding
editor: Patryk <patryk@status.im>
contributors: Jazz <jazz@status.im>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
contributors: Jazz <jazz@status.im>
contributors: Jazzz <jazz@status.im>

Comment on lines +129 to +136
#### Encoding Steps

1. Construct the `IntroBundle` protobuf message.
2. Serialize using proto3 encoding (~134 bytes).
3. Encode as base64url without padding (~179 characters).
4. Prepend the preamble with version prefix.

The resulting string is ~197 printable ASCII characters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under the heading "Implementation suggestions" however I don't see any suggestions here.


## Implementation Suggestions

### V1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having multiple V1s in the document is not easy to follow.

I'd either remove the potential for V2 for now. Or write it in a way that V1 can be described using only the ##Parameters section in a n appendix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants