feat: add ListMixin and implement Redis list operations#802
Open
oliverhaas wants to merge 4 commits intojazzband:masterfrom
Open
feat: add ListMixin and implement Redis list operations#802oliverhaas wants to merge 4 commits intojazzband:masterfrom
oliverhaas wants to merge 4 commits intojazzband:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #802 +/- ##
========================================
- Coverage 38.2% 37.0% -1.1%
========================================
Files 48 50 +2
Lines 3727 3993 +266
Branches 301 336 +35
========================================
+ Hits 1420 1476 +56
- Misses 2006 2181 +175
- Partials 301 336 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changed list method parameters to use 'key' instead of 'name' to align with Redis/Valkey terminology and maintain consistency with other django-redis methods. All 10 list methods updated: - lpush(key, *values, ...) - rpush(key, *values, ...) - lpop(key, count, ...) - rpop(key, count, ...) - lrange(key, start, end, ...) - lindex(key, index, ...) - llen(key, ...) - lrem(key, count, value, ...) - ltrim(key, start, end, ...) - lset(key, index, value, ...) All 192 list operation tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.