Push Connection Factory setting to options#620
Open
vedantpuri wants to merge 4 commits intojazzband:masterfrom
Open
Push Connection Factory setting to options#620vedantpuri wants to merge 4 commits intojazzband:masterfrom
vedantpuri wants to merge 4 commits intojazzband:masterfrom
Conversation
vedantpuri
commented
Oct 21, 2022
Comment on lines
62
to
68
| # First check if local override provided, else fall back to settings | ||
| connection_factory_path = self._options.get( | ||
| "CONNECTION_FACTORY", | ||
| settings.get( | ||
| "DJANGO_REDIS_CONNECTION_FACTORY", "django_redis.pool.ConnectionFactory" | ||
| ), | ||
| ) |
Member
There was a problem hiding this comment.
there is not only 'defaultClient'
Author
There was a problem hiding this comment.
I didn't follow this comment, could you elaborate ?
Author
There was a problem hiding this comment.
Following up on this if you could clarify a bit further
Member
There was a problem hiding this comment.
sorry for the late reply, I mean that there is not only DefaultClient but also others... but now I see that others all use connection factory of the parent class which is DefaultClient
Member
There was a problem hiding this comment.
Also why moving this logic to DefaultClient? it makes testing more difficult... please move it back, add tests and changelog file
WisdomPill
requested changes
Oct 21, 2022
Member
WisdomPill
left a comment
WisdomPill
left a comment
There was a problem hiding this comment.
There is not only DefaultClient and testing is needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for #619