Ignore null changeset on creation and deletion#282
Open
joeyjoejoejr wants to merge 2 commits intojazzband:masterfrom
Open
Ignore null changeset on creation and deletion#282joeyjoejoejr wants to merge 2 commits intojazzband:masterfrom
joeyjoejoejr wants to merge 2 commits intojazzband:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
==========================================
- Coverage 82.20% 82.02% -0.19%
==========================================
Files 18 18
Lines 489 495 +6
==========================================
+ Hits 402 406 +4
- Misses 87 89 +2 ☔ View full report in Codecov by Sentry. |
Member
|
Thanks @joeyjoejoejr for the patch 👍 |
Member
|
@hramezani I think will be solved as a side-effect of #483. We might still need the tests but let's evaluate after we merge #483. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I registered a nullable field of a model using
include_fields. There was a a check for nullchangesin thelog_updatereceiver, but not thelog_createandlog_deleteones. This meant that a log entry was created withnullfor the changes field whenever a model was created or updated, but didn't have a value for that field.When the mixin method
msg_shortis called in the Audit Log admin index, it would error because it's expecting an object for changes.What Changed:
log_createandlog_deleteto make sure entries aren't created if the changes are None.