Open
Conversation
Contributor
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
DMartens
reviewed
Feb 11, 2026
knip.json
Outdated
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "$schema": "https://unpkg.com/knip@5/schema.json", | |||
| "entry": ["tests/**/*.{cts,js,ts}"] | |||
There was a problem hiding this comment.
Knip does not seem to recognize the glob pattern in the package.json test script.
The knip documentation advices to use --production instead of ignoring the test files.
Contributor
Author
There was a problem hiding this comment.
Sorry, are you suggesting we change something here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Adds Knip to check for unused exports, unused dependencies, and missing dependencies
What changes did you make? (Give an overview)
knip.jsonconfig and a rootlint:unusedscript.BASELINE_FALSEexportRelated Issues
eslint/js#695
Is there anything you'd like reviewers to focus on?