Skip to content

Close: Lastgenre: Split last.fm fetching and file loading to separate files#6353

Closed
JOJ0 wants to merge 11 commits intobeetbox:masterfrom
JOJ0:lastgenre_split_monolith
Closed

Close: Lastgenre: Split last.fm fetching and file loading to separate files#6353
JOJ0 wants to merge 11 commits intobeetbox:masterfrom
JOJ0:lastgenre_split_monolith

Conversation

@JOJ0
Copy link
Member

@JOJ0 JOJ0 commented Feb 7, 2026

closed in favor of #6368

@JOJ0 JOJ0 added lastgenre plugin Pull requests that are plugins related labels Feb 7, 2026
@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 74.35897% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.00%. Comparing base (bc52682) to head (011012c).
⚠️ Report is 15 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
beetsplug/lastgenre/client.py 55.10% 21 Missing and 1 partial ⚠️
beetsplug/lastgenre/__init__.py 74.35% 5 Missing and 5 partials ⚠️
beetsplug/lastgenre/types.py 0.00% 5 Missing ⚠️
beetsplug/lastgenre/utils.py 75.00% 2 Missing ⚠️
beetsplug/lastgenre/loaders.py 98.18% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6353      +/-   ##
==========================================
+ Coverage   68.97%   69.00%   +0.03%     
==========================================
  Files         140      144       +4     
  Lines       18694    18730      +36     
  Branches     3060     3057       -3     
==========================================
+ Hits        12894    12925      +31     
- Misses       5153     5160       +7     
+ Partials      647      645       -2     
Files with missing lines Coverage Δ
beetsplug/lastgenre/loaders.py 98.18% <98.18%> (ø)
beetsplug/lastgenre/utils.py 75.00% <75.00%> (ø)
beetsplug/lastgenre/types.py 0.00% <0.00%> (ø)
beetsplug/lastgenre/__init__.py 72.08% <74.35%> (+1.93%) ⬆️
beetsplug/lastgenre/client.py 55.10% <55.10%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JOJ0 JOJ0 added this to the 2.7.0 milestone Feb 7, 2026
@JOJ0 JOJ0 marked this pull request as ready for review February 7, 2026 19:46
@JOJ0 JOJ0 requested a review from a team as a code owner February 7, 2026 19:46
@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@JOJ0 JOJ0 force-pushed the lastgenre_split_monolith branch from 4788814 to 5eabd4c Compare February 7, 2026 20:01
JOJ0 added a commit to JOJ0/beets that referenced this pull request Feb 8, 2026
JOJ0 added a commit to JOJ0/beets that referenced this pull request Feb 8, 2026
@JOJ0 JOJ0 force-pushed the lastgenre_split_monolith branch from 8c8b9d3 to 51f8638 Compare February 8, 2026 08:26
JOJ0 added a commit to JOJ0/beets that referenced this pull request Feb 10, 2026
@JOJ0 JOJ0 force-pushed the lastgenre_split_monolith branch from 83a5311 to f3fbc13 Compare February 10, 2026 09:35
JOJ0 added a commit to JOJ0/beets that referenced this pull request Feb 10, 2026
@JOJ0 JOJ0 force-pushed the lastgenre_split_monolith branch from f3fbc13 to fb01cac Compare February 10, 2026 09:36
@JOJ0 JOJ0 force-pushed the lastgenre_split_monolith branch from fb01cac to 9116de0 Compare February 11, 2026 07:41
- Define types for whitelist and canonicalization tree
- Better document the flatten_tree function
@JOJ0 JOJ0 force-pushed the lastgenre_split_monolith branch from c22915d to 011012c Compare February 15, 2026 14:41
@JOJ0 JOJ0 changed the title Lastgenre: Split last.fm fetching and file loading to separate files Close: Lastgenre: Split last.fm fetching and file loading to separate files Feb 15, 2026
@JOJ0 JOJ0 closed this Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lastgenre plugin Pull requests that are plugins related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant