Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the configuration files to support ESLint 9 by refining type imports and restructuring configuration objects into arrays when needed. Key changes include replacing regular imports with type-only imports for ESLint’s Linter, updating configuration types from ConfigOverride to Config, and refactoring setup for various language-specific ESLint plugins.
Reviewed Changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugin-node-rules.cts | Changed import to type-only for ESLint’s Linter |
| src/plugin-import-rules.cts | Changed import to type-only for ESLint’s Linter |
| src/official-eslint-rules.cts | Changed import to type-only for ESLint’s Linter |
| src/json.cts | Updated configuration type and plugin usage |
| src/javascript.cts | Updated jsConfig type to an array and refined parser options |
| src/index.cts | Updated config structure to an array and import changes |
| src/index-strict*.cts | Commented out removal of only-warn for non-strict configurations |
| src/index-solid.cts | Refactored solid config integration |
| src/index-react.cts | Refactored react config integration |
| src/html.cts | Updated html config to use object style plugins |
| src/cson.cts | Updated cson config to new configuration type |
| src/coffeescript.cts | Updated coffeescript config to new configuration type |
| src/astro.cts | Updated astro config to array-based configuration |
| prettier.config.mjs | Added prettier configuration import |
| eslint.config.cjs | Updated export to spread the array configuration |
Files not reviewed (2)
- .eslintrc.json: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/index.cts:7
- The variable name 'pluginOptmizeRegex' appears to contain a typo; consider renaming it to 'pluginOptimizeRegex' for clarity.
import pluginOptmizeRegex from "eslint-plugin-optimize-regex"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.